Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controller] Update hostname if provided by the client #305

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

okraits
Copy link
Member

@okraits okraits commented Oct 13, 2020

Fixes #293

@TravisBuddy
Copy link

Travis tests have failed

Hey @okraits,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

6th Build

View build log

./run-qa-checks
SUCCESS: Blank endline check successful!
SUCCESS: Migration name check on "./openwisp_controller/config/migrations" with migrations-to-ignore: 12 successful!
SUCCESS: Migration name check on "./openwisp_controller/connection/migrations" with migrations-to-ignore: 0 successful!
SUCCESS: Migration name check on "./openwisp_controller/geo/migrations" with migrations-to-ignore: 0 successful!
SUCCESS: Migration name check on "./openwisp_controller/pki/migrations" with migrations-to-ignore: 4 successful!
Skipped 1 files
SUCCESS: Isort check successful!
All done! ✨ 🍰 ✨
192 files would be left unchanged.
SUCCESS: Black check successful!
SUCCESS: Flake8 check successful!
Your commit message does not follow our commit message style guidelines:

- if you mention an issue in the long description, please show it in the short description too
  eg: [prefix] Action performed #234

      Long desc. Closes #234

Please read our guidelines at: http://openwisp.io/docs/developer/contributing.html#commit-message-style-guidelines
Checked commit message:


[controller] Update hostname if provided by the client

Fixes #293


ERROR: Commit message check failed!
No changes detected
SUCCESS: Migrations check successful!
TravisBuddy Request Identifier: 05251310-0d2c-11eb-9111-f326d0cb7f09

@okraits okraits force-pushed the tdt-update-hostname branch from 731e719 to b643d68 Compare October 13, 2020 09:11
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.288% when pulling b643d68 on TDT-AG:tdt-update-hostname into 53da00c on openwisp:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[controller] Device name changed by a template is not updated in the device model instance
3 participants